Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the option to provide a groupname and only see its' members in occ group:list #49016

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Add the option to provide a groupname and only see its' members in occ group:list #49016

merged 2 commits into from
Feb 3, 2025

Conversation

Keeper-of-the-Keys
Copy link
Contributor

@Keeper-of-the-Keys Keeper-of-the-Keys commented Oct 30, 2024 •
edited
Loading

Summary

As the title states this adds an optional groupname argument to occ group:list so you can see the members of just that group.

Now you can do occ group:list groupname

If the change is welcome I can work on the further needed steps to get it in.

TODO

  1. Fail/return error if group doesn't exist
  2. Only print the members and not the groupname

Checklist

@Keeper-of-the-Keys Keeper-of-the-Keys force-pushed the occ-groups-list-single-group branch from bd2d651 to 7b82a6a Compare October 30, 2024 13:34
@joshtrichards joshtrichards added this to the Nextcloud 31 milestone Oct 31, 2024
@Keeper-of-the-Keys
Copy link
Contributor Author

@joshtrichards Hey thanks for tagging/milestoning!

Is there anything I can do to help move things along?

@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@blizzz blizzz mentioned this pull request Jan 8, 2025
Merged
@Keeper-of-the-Keys @AndyScherzinger
Add the option to provide a groupname and only see its' members.
c7acab5 
Improvements/TODO:
1. Fail/return error if group doesn't exist
2. Only print the members and not the groupname

Signed-off-by: E.S. Rosenberg a.k.a. Keeper of the Keys <[email protected]>
@AndyScherzinger AndyScherzinger force-pushed the occ-groups-list-single-group branch from 8ef7a7d to c7acab5 Compare January 8, 2025 19:14
come-nc
come-nc requested changes Jan 9, 2025
View reviewed changes
core/Command/Group/ListCommand.php Outdated Show resolved Hide resolved
core/Command/Group/ListCommand.php Outdated Show resolved Hide resolved
core/Command/Group/ListCommand.php Outdated Show resolved Hide resolved
core/Command/Group/ListCommand.php Outdated Show resolved Hide resolved
This was referenced Jan 14, 2025
Merged
Merged
This was referenced Jan 21, 2025
Merged
Merged
@blizzz blizzz mentioned this pull request Jan 29, 2025
Merged
1 task
@blizzz blizzz modified the milestones: Nextcloud 31, Nextcloud 32 Jan 29, 2025
@come-nc
fix: Clearly document that the argument is a search string
5e97a46 
It is not an exact match on the group id

Signed-off-by: Côme Chilliet <[email protected]>
@sorbaugh sorbaugh merged commit 8aad48c into nextcloud:master Feb 3, 2025
175 of 179 checks passed
@welcome Welcome
Copy link

welcome bot commented Feb 3, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@come-nc
Copy link
Contributor

come-nc commented Feb 3, 2025

@Keeper-of-the-Keys Thank you for your contribution!
Would you be interested in a guest account on our Nextcloud Talk instance ? It hosts a dev chat for community. I can send an invite to the email you used in the commits if that’s okay with you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@Altahrim Altahrim Altahrim approved these changes

@sorbaugh sorbaugh Awaiting requested review from sorbaugh

Assignees
No one assigned
Labels
3. to review Waiting for reviews enhancement feedback-requested
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
6 participants
@Keeper-of-the-Keys @come-nc @Altahrim @joshtrichards @blizzz @sorbaugh